Upgrade to Embree 4 #3635
Closed
Upgrade to Embree 4 #3635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
Filed as internal issue #USD-11010 (This is an automated message. See here for more information.) |
Collaborator
Author
|
Ah good call @mattyjams. We should consolidate to one and then figure out how to land it. |
Contributor
|
PR 2313 has been landed and will go out with 25.11. Closing this as a duplicate. (When it rains, it pours! Embree 3 stopped working in a ton of different configs this June...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Embree 3 has compiler issues with the latest versions of Clang. While we could opt to add patches in the build_usd.py to make it pass, it feels like there's better incentive to just move to newer Embree since it's not production critical, but is useful for validations.
I did consider keeping support for Embree 3 in addition to Embree 4, but for the same reason, it felt like it would just overcomplicate things given the limitations of the current Embree backend.
Posting this PR on behalf of Maddy Adams
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)